Java patches rebase #4716
Merged
Java patches rebase #4716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridiver
commented
Feb 21, 2020
| import org.objectweb.asm.ClassReader; | ||
| import org.objectweb.asm.ClassVisitor; | ||
| import org.objectweb.asm.ClassWriter; | ||
| +import org.objectweb.asm.Opcodes; |
bridiver
commented
Feb 21, 2020
| + chain = org.brave.bytecode.BraveClassAdapter.createAdapter(chain); | ||
| reader.accept(chain, 0); | ||
| byte[] patchedByteCode = writer.toByteArray(); | ||
| + |
There was a problem hiding this comment.
also removing these empty lines added
|
We will need to describe how to create such patches in wiki |
bridiver
added
CI/skip-ios
bridiver
force-pushed
the
java-patches-rebase
branch
from
a66eaa0
to
6543cc5
Compare
|
Updated this PR and the issue to set 1.7 milestone (current master) |
brave-builds
pushed a commit
that referenced
this pull request
Mar 10, 2020
brave-builds
pushed a commit
that referenced
this pull request
Mar 10, 2020
This was referenced Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#8557
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.